JingsongLi commented on code in PR #6755:
URL: https://github.com/apache/paimon/pull/6755#discussion_r2594776892
##########
paimon-common/src/main/java/org/apache/paimon/utils/FileBasedBloomFilter.java:
##########
@@ -34,16 +35,18 @@
/** Util to apply a built bloom filter . */
public class FileBasedBloomFilter implements Closeable {
- private final PageFileInput input;
+ private final SeekableInputStream input;
private final CacheManager cacheManager;
private final BloomFilter filter;
private final long readOffset;
- private final int readLength;
private final CacheKey cacheKey;
+ // each bloom filter is only used by a single file reader, so we can
safely reuse here
+ private final byte[] reusedPageBuffer;
Review Comment:
Do not introduce this, when memory preemption occurs, it's precisely when
memory usage needs to be cleaned up. Your way of referencing it makes it
impossible to clean up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
