guluo2016 commented on code in PR #6768:
URL: https://github.com/apache/paimon/pull/6768#discussion_r2602114985
##########
paimon-arrow/src/test/java/org/apache/paimon/arrow/vector/ArrowFormatWriterTest.java:
##########
@@ -433,6 +438,55 @@ public void testWriteRowArrayTwice() {
}
}
+ @Test
+ public void testTimeFieldWriterWithOffset() {
+ RowType rowType =
+ new RowType(
+ Collections.singletonList(
+ new DataField(0, "time_field",
DataTypes.TIME())));
+ try (RootAllocator allocator = new RootAllocator();
+ VectorSchemaRoot vsr =
ArrowUtils.createVectorSchemaRoot(rowType, allocator)) {
+ ArrowFieldWriter[] fieldWriters =
ArrowUtils.createArrowFieldWriters(vsr, rowType);
+
+ IntColumnVector timeVec =
+ new IntColumnVector() {
+ final int[] values = new int[] {0, 1000, 2000, 3000,
4000};
Review Comment:
I didn’t modify `ArrowFieldWriters.java` to keep it consistent with the rest
of the code.
Updating the test case to improve readability, thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
