yunfengzhou-hub commented on code in PR #6728:
URL: https://github.com/apache/paimon/pull/6728#discussion_r2605774971


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/lookup/PartitionLoader.java:
##########
@@ -76,7 +76,7 @@ public void addPartitionKeysTo(List<String> joinKeys, 
List<String> projectFields
         partitionKeys.stream().filter(k -> 
!projectFields.contains(k)).forEach(projectFields::add);
     }
 
-    public Predicate createSpecificPartFilter() {
+    public Predicate createSpecificPartFilter(List<BinaryRow> partitions) {

Review Comment:
   It might be better to make this method static, or further move this method 
to some utility method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to