steFaiz commented on code in PR #6796:
URL: https://github.com/apache/paimon/pull/6796#discussion_r2609076732
##########
paimon-common/src/main/java/org/apache/paimon/sst/SstFileWriter.java:
##########
@@ -67,14 +81,16 @@ public class SstFileWriter implements Closeable {
private static final Logger LOG =
LoggerFactory.getLogger(SstFileWriter.class.getName());
public static final int MAGIC_NUMBER = 1481571681;
+ public static final int VERSION = 1;
Review Comment:
Ok, Thanks! I will modify this soon. I was thinking about version is easier
to understand if we want to evolve the file format. For example, `if (version
== 1)` is clearer than `if (magic_number == 187762739)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
