XiaoHongbo-Hope commented on code in PR #6808: URL: https://github.com/apache/paimon/pull/6808#discussion_r2613958513
########## paimon-python/pypaimon/common/options/options.py: ########## @@ -0,0 +1,58 @@ +""" +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +""" + +from pypaimon.common.options import ConfigOption +from pypaimon.common.options.options_utils import OptionsUtils + + +class Options: + def __init__(self, data: dict): + self.data = data + + @classmethod + def from_none(cls): + return cls({}) + + def to_map(self) -> dict: + return self.data + + def get(self, key: ConfigOption, default=None): + """ Review Comment: I perfer to support both str and ConfigOption here. If ConfigOption only, can you please test whether these code in file_io.py works will, client_kwargs['endpoint_override'] = self.properties.get(OssOptions.OSS_ENDPOINT) and other cases like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
