JingsongLi commented on code in PR #6801: URL: https://github.com/apache/paimon/pull/6801#discussion_r2621698745
########## paimon-core/src/main/java/org/apache/paimon/io/ChainKeyValueFileReaderFactory.java: ########## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.io; + +import org.apache.paimon.CoreOptions; +import org.apache.paimon.data.BinaryRow; +import org.apache.paimon.deletionvectors.DeletionVector; +import org.apache.paimon.fs.FileIO; +import org.apache.paimon.schema.SchemaManager; +import org.apache.paimon.schema.TableSchema; +import org.apache.paimon.types.RowType; +import org.apache.paimon.utils.FormatReaderMapping; + +/** A specific implementation about {@link KeyValueFileReaderFactory} for chain split. */ +public class ChainKeyValueFileReaderFactory extends KeyValueFileReaderFactory { + + private final ReadContext readContext; + + private final String currentBranch; + + public ChainKeyValueFileReaderFactory( + FileIO fileIO, + SchemaManager schemaManager, + TableSchema schema, + RowType keyType, + RowType valueType, + FormatReaderMapping.Builder formatReaderMappingBuilder, + DataFilePathFactory pathFactory, + long asyncThreshold, + BinaryRow partition, + DeletionVector.Factory dvFactory, + ReadContext readContext) { + super( + fileIO, + schemaManager, + schema, + keyType, + valueType, + formatReaderMappingBuilder, + pathFactory, + asyncThreshold, + partition, + dvFactory); + this.readContext = readContext; + CoreOptions options = new CoreOptions(schema.options()); + this.currentBranch = options.branch(); + } + + @Override + protected TableSchema getDataSchema(DataFileMeta fileMeta) { + String branch = readContext.fileBranchMapping().get(fileMeta.fileName()); + if (currentBranch.equalsIgnoreCase(branch)) { + super.getDataSchema(fileMeta); + } + // todo: support get data schema according to branch + return null; Review Comment: Implement this? ########## paimon-core/src/main/java/org/apache/paimon/io/ReadContext.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.io; + +import org.apache.paimon.data.BinaryRow; + +import java.util.Map; + +/** Information to read the file. */ +public class ReadContext { Review Comment: ChainReadContext ########## paimon-core/src/main/java/org/apache/paimon/operation/MergeFileSplitRead.java: ########## @@ -277,6 +291,42 @@ public RecordReader<KeyValue> createReader(Split s) throws IOException { } } + public RecordReader<KeyValue> createReader(ChainSplit chainSplit) throws IOException { Review Comment: createChainReader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
