zhoulii commented on code in PR #6861:
URL: https://github.com/apache/paimon/pull/6861#discussion_r2642570796
##########
paimon-python/pypaimon/write/table_write.py:
##########
@@ -80,15 +81,42 @@ def _validate_pyarrow_schema(self, data_schema: pa.Schema):
class BatchTableWrite(TableWrite):
- def __init__(self, table, commit_user):
+ def __init__(self, table, commit_user, update_columns_by_row_id=False):
super().__init__(table, commit_user)
self.batch_committed = False
+ self._partial_column_write: Optional[PartialColumnWrite] = None
+ if update_columns_by_row_id:
+ self._partial_column_write = PartialColumnWrite(self.table,
self.commit_user)
+
+ def write_arrow(self, table: pa.Table):
+ if self._partial_column_write is not None:
Review Comment:
I haven't figured out the exact approach yet, so I just deleted the else
branch for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
