discivigour commented on code in PR #6944:
URL: https://github.com/apache/paimon/pull/6944#discussion_r2659300991
##########
paimon-python/pypaimon/read/table_scan.py:
##########
@@ -71,3 +71,11 @@ def _create_starting_scanner(self) ->
Optional[StartingScanner]:
def with_shard(self, idx_of_this_subtask, number_of_para_subtasks) ->
'TableScan':
self.starting_scanner.with_shard(idx_of_this_subtask,
number_of_para_subtasks)
return self
+
+ def with_row_range(self, start_row, end_row) -> 'TableScan':
+ """
+ Filter file entries by row range. The row_id corresponds to the row
position of the
+ file in all file entries in table scan's partitioned_files.
+ """
Review Comment:
It might be better to clearly describe the inclusion and exclusion of idx
within the range in the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
