FreemanDane commented on code in PR #6883:
URL: https://github.com/apache/paimon/pull/6883#discussion_r2659488411


##########
paimon-python/pypaimon/write/table_write.py:
##########
@@ -68,6 +68,11 @@ def with_write_type(self, write_cols: List[str]):
         self.file_store_write.write_cols = write_cols
         return self
 
+    def write_raydata(self, dataset, overwrite=False, parallelism=1):
+        from pypaimon.write.ray_datasink import PaimonDatasink
+        datasink = PaimonDatasink(dataset, overwrite=overwrite)
+        dataset.write_datasink(datasink, concurrency=parallelism)
+        

Review Comment:
   However,the Dataset class is defined by Ray, and so is its method write_xxx. 
I think it need to create a PR on Ray? The api in paimon calls 
TableWrite.write_raydata.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to