steFaiz commented on code in PR #6986:
URL: https://github.com/apache/paimon/pull/6986#discussion_r2672452552


##########
paimon-core/src/main/java/org/apache/paimon/table/system/FilesTable.java:
##########
@@ -117,7 +119,10 @@ public class FilesTable implements ReadonlyTable {
                             new DataField(14, "max_sequence_number", new 
BigIntType(true)),
                             new DataField(15, "creation_time", 
DataTypes.TIMESTAMP_MILLIS()),
                             new DataField(16, "deleteRowCount", 
DataTypes.BIGINT()),
-                            new DataField(17, "file_source", 
DataTypes.STRING())));
+                            new DataField(17, "file_source", 
DataTypes.STRING()),
+                            new DataField(18, "first_row_id", 
DataTypes.BIGINT()),
+                            new DataField(19, "write_cols", 
DataTypes.ARRAY(DataTypes.STRING())),
+                            new DataField(20, "blob", DataTypes.BOOLEAN())));

Review Comment:
   Thanks for your advise! I was thinking that this is convenient for sql. For 
example, if we want to calculate all blob's storage, we just need to write 
`where T.blob = true` instead of `where T.fileName LIKE '%s.blob'`.
   Would you be okay with keeping this boolean field, or do you prefer avoid 
persisting redundant metadata?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to