JingsongLi commented on code in PR #7014:
URL: https://github.com/apache/paimon/pull/7014#discussion_r2684876537


##########
paimon-python/pypaimon/read/split.py:
##########
@@ -34,6 +34,7 @@ class Split:
     _row_count: int
     _file_size: int
     shard_file_idx_map: Dict[str, Tuple[int, int]] = 
field(default_factory=dict)  # file_name -> (start_idx, end_idx)
+    sample_file_idx_map: Dict[str, List[int]] = field(default_factory=dict)  # 
file_name -> [sample_indexes]

Review Comment:
   We need to merge `sample_file_idx_map` into `shard_file_idx_map`, maybe just 
introduce `shard_file_idx_map: Dict[str, List[Range]]`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to