plusplusjiajia commented on code in PR #6993:
URL: https://github.com/apache/paimon/pull/6993#discussion_r2685292296
##########
paimon-common/src/main/java/org/apache/paimon/predicate/Predicate.java:
##########
@@ -32,8 +35,16 @@
* @since 0.4.0
*/
@Public
+@JsonTypeInfo(
+ use = JsonTypeInfo.Id.NAME,
+ include = JsonTypeInfo.As.PROPERTY,
+ property = Predicate.FIELD_PREDICATE)
+@JsonSubTypes({
+ @JsonSubTypes.Type(value = LeafPredicate.class, name = LeafPredicate.NAME),
+ @JsonSubTypes.Type(value = CompoundPredicate.class, name =
CompoundPredicate.NAME)
+})
public interface Predicate extends Serializable {
-
+ String FIELD_PREDICATE = "predicate";
Review Comment:
> Let's modify it to `kind`?
done
##########
paimon-common/src/main/java/org/apache/paimon/predicate/Transform.java:
##########
@@ -21,11 +21,26 @@
import org.apache.paimon.data.InternalRow;
import org.apache.paimon.types.DataType;
+import
org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonSubTypes;
+import
org.apache.paimon.shade.jackson2.com.fasterxml.jackson.annotation.JsonTypeInfo;
+
import java.io.Serializable;
import java.util.List;
/** Represents a transform function. */
+@JsonTypeInfo(
+ use = JsonTypeInfo.Id.NAME,
+ include = JsonTypeInfo.As.PROPERTY,
+ property = Transform.FIELD_TRANSFORM)
+@JsonSubTypes({
+ @JsonSubTypes.Type(value = FieldTransform.class, name =
FieldTransform.NAME),
+ @JsonSubTypes.Type(value = CastTransform.class, name = CastTransform.NAME),
+ @JsonSubTypes.Type(value = ConcatTransform.class, name =
ConcatTransform.NAME),
+ @JsonSubTypes.Type(value = ConcatWsTransform.class, name =
ConcatWsTransform.NAME),
+ @JsonSubTypes.Type(value = UpperTransform.class, name =
UpperTransform.NAME)
+})
public interface Transform extends Serializable {
+ String FIELD_TRANSFORM = "transform";
Review Comment:
> "name" is better.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
