JingsongLi commented on code in PR #7034:
URL: https://github.com/apache/paimon/pull/7034#discussion_r2686441644


##########
paimon-core/src/main/java/org/apache/paimon/table/source/ReadBuilderImpl.java:
##########
@@ -256,6 +258,20 @@ public TableRead newRead() {
         if (variantAccessInfo != null) {
             read.withVariantAccess(variantAccessInfo);
         }
+        if (table instanceof FileStoreTable) {
+            CoreOptions options = new CoreOptions(table.options());
+            if (options.queryAuthEnabled()) {
+                TableQueryAuth queryAuth =
+                        ((FileStoreTable) 
table).catalogEnvironment().tableQueryAuth(options);
+                TableQueryAuthResult authResult =
+                        queryAuth.auth(readType == null ? null : 
readType.getFieldNames());

Review Comment:
   New Read will invoked in every works. We should not let so many works to do 
RPC to metastore.
   
   I think maybe we can introduce `QueryAuthSplit` with filter and masking. And 
here wrapping new TableRead to do filter and masking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to