XiaoHongbo-Hope commented on code in PR #7001:
URL: https://github.com/apache/paimon/pull/7001#discussion_r2687182255
##########
paimon-python/pypaimon/common/file_io.py:
##########
@@ -39,6 +40,8 @@
class FileIO:
+ _RENAME_LOCK = threading.Lock()
+
def __init__(self, path: str, catalog_options: Options):
self.properties = catalog_options
self.logger = logging.getLogger(__name__)
Review Comment:
> The class-level lock _RENAME_LOCK is shared across all FileIO instances.
This means that rename operations on different FileIO instances (e.g.,
different warehouses or filesystems) will block each other unnecessarily.
Consider using an instance-level lock instead, or document this limitation.
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
