JingsongLi commented on code in PR #7055:
URL: https://github.com/apache/paimon/pull/7055#discussion_r2700634585


##########
paimon-format/src/main/java/org/apache/paimon/format/blob/BlobFormatWriter.java:
##########
@@ -55,21 +55,21 @@ public BlobFormatWriter(PositionOutputStream out) {
     @Override
     public void addElement(InternalRow element) throws IOException {
         checkArgument(element.getFieldCount() == 1, "BlobFormatWriter only 
support one field.");
-        checkArgument(!element.isNullAt(0), "BlobFormatWriter only support 
non-null blob.");
-        Blob blob = element.getBlob(0);
 
         long previousPos = out.getPos();
-        crc32.reset();
-
         write(MAGIC_NUMBER_BYTES);

Review Comment:
   Why we need to write magic number for null blob?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to