YannByron commented on code in PR #7097:
URL: https://github.com/apache/paimon/pull/7097#discussion_r2739895731
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/extensions/PaimonSparkSessionExtensions.scala:
##########
@@ -51,6 +51,8 @@ class PaimonSparkSessionExtensions extends
(SparkSessionExtensions => Unit) {
extensions.injectPostHocResolutionRule(_ => PaimonDeleteTable)
extensions.injectPostHocResolutionRule(spark => PaimonMergeInto(spark))
+ extensions.injectPostHocResolutionRule(_ => RewritePaimonV2UpdateTable)
Review Comment:
I suggest use one single-rule to deal with update operations. In it, we can
always align assignments first, and then chose the v1/v2 code plan.
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/extensions/PaimonSparkSessionExtensions.scala:
##########
@@ -51,6 +51,8 @@ class PaimonSparkSessionExtensions extends
(SparkSessionExtensions => Unit) {
extensions.injectPostHocResolutionRule(_ => PaimonDeleteTable)
extensions.injectPostHocResolutionRule(spark => PaimonMergeInto(spark))
+ extensions.injectPostHocResolutionRule(_ => RewritePaimonV2UpdateTable)
Review Comment:
I suggest to use one single-rule to deal with update operations. In it, we
can always align assignments first, and then chose the v1/v2 code plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
