JingsongLi commented on code in PR #7012:
URL: https://github.com/apache/paimon/pull/7012#discussion_r2757525734
##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -1446,6 +1446,24 @@
<td>String</td>
<td>The Variant shredding schema for writing.</td>
</tr>
+ <tr>
+ <td><h5>vector-store.fields</h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify the vector store fields.</td>
+ </tr>
+ <tr>
+ <td><h5>vector-store.format</h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify the vector store file format.</td>
+ </tr>
+ <tr>
+ <td><h5>vector-store.target-file-size</h5></td>
Review Comment:
vector.target-file-size
##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -1446,6 +1446,24 @@
<td>String</td>
<td>The Variant shredding schema for writing.</td>
</tr>
+ <tr>
+ <td><h5>vector-store.fields</h5></td>
+ <td style="word-wrap: break-word;">(none)</td>
+ <td>String</td>
+ <td>Specify the vector store fields.</td>
+ </tr>
+ <tr>
+ <td><h5>vector-store.format</h5></td>
Review Comment:
vector.file.format
##########
paimon-core/src/main/java/org/apache/paimon/append/dataevolution/DataEvolutionCompactTask.java:
##########
@@ -89,11 +92,33 @@ public CommitMessage doCompact(FileStoreTable table, String
commitUser) throws E
table = table.copy(DYNAMIC_WRITE_OPTIONS);
long firstRowId = compactBefore.get(0).nonNullFirstRowId();
- RowType readWriteType =
+ List<String> vectorStoreFieldNames =
table.coreOptions().vectorStoreFieldNames();
Review Comment:
Why here need to deal with `vectorStoreFieldNames`? If you take a look to
blob-field, only engines need to handle it.
##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -1446,6 +1446,24 @@
<td>String</td>
<td>The Variant shredding schema for writing.</td>
</tr>
+ <tr>
+ <td><h5>vector-store.fields</h5></td>
Review Comment:
vector-field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
