junmuz commented on code in PR #7218:
URL: https://github.com/apache/paimon/pull/7218#discussion_r2770023666
##########
paimon-core/src/main/java/org/apache/paimon/catalog/RenamingSnapshotCommit.java:
##########
@@ -54,6 +55,17 @@ public boolean commit(Snapshot snapshot, String branch,
List<PartitionStatistics
? snapshotManager.snapshotPath(snapshot.id())
:
snapshotManager.copyWithBranch(branch).snapshotPath(snapshot.id());
+ // Use native conditional writes if supported
Review Comment:
I think overriding the method `tryToWriteAtomic` would be better as it is
used at different places. Perhaps we can leverage the same property
`fs.s3a.create.conditional.enabled`
(https://github.com/apache/hadoop/blob/8222ac0f546911b387b6a141e06dd8bf5306d565/hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/troubleshooting_s3a.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
