JingsongLi commented on code in PR #7216:
URL: https://github.com/apache/paimon/pull/7216#discussion_r2788607230
##########
paimon-common/src/main/java/org/apache/paimon/data/BlobDescriptor.java:
##########
@@ -113,10 +114,11 @@ public byte[] serialize() {
byte[] uriBytes = uri.getBytes(UTF_8);
int uriLength = uriBytes.length;
- int totalSize = 1 + 4 + uriLength + 8 + 8;
+ int totalSize = 8 + 1 + 4 + uriLength + 8 + 8;
ByteBuffer buffer = ByteBuffer.allocate(totalSize);
buffer.order(ByteOrder.LITTLE_ENDIAN);
+ buffer.putLong(MAGIC);
Review Comment:
I think in order to be compatible with older versions, we should design
Magic Numbers after the version number, and Linux kernel images are designed in
this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
