gmdfalk commented on code in PR #7315:
URL: https://github.com/apache/paimon/pull/7315#discussion_r2876959500
##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/format/AbstractDataFormat.java:
##########
@@ -55,9 +55,8 @@ public AbstractRecordParser createParser(
TypeMapping typeMapping,
List<ComputedColumn> computedColumns,
CdcMetadataConverter[] metadataConverters) {
- // Most parsers don't support metadata converters, so we default to
the 2-parameter version
- // Only specific parsers like DebeziumAvroRecordParser will override
this
- return createParser(typeMapping, computedColumns);
Review Comment:
i initially scoped the change just to Debezium Avro format because that's
what we were using and I wanted to get tests to pass there first. Since the
other formats and tests are so similar, it would then have been a small jump to
add it to all of them.
But turns out this was the exact choice that blocked me from testing it
successfully, so thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
