XiaoHongbo-Hope commented on code in PR #110: URL: https://github.com/apache/paimon-rust/pull/110#discussion_r2901311770
########## crates/paimon/src/deletion_vector/core.rs: ########## @@ -0,0 +1,185 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +#![allow(dead_code)] + +use roaring::RoaringBitmap; +use std::sync::Arc; + +/// DeletionVector represents a set of row positions that have been deleted. +/// Uses RoaringBitmap for efficient storage, similar to Java's BitmapDeletionVector. +/// +/// Impl Reference: <https://github.com/apache/paimon/blob/release-1.3/paimon-core/src/main/java/org/apache/paimon/deletionvectors/BitmapDeletionVector.java> +#[derive(Debug, Clone)] +pub struct DeletionVector { + /// RoaringBitmap storing deleted row positions (0-indexed) + /// Using u32 as RoaringBitmap32 in Java supports up to 2^31-1 rows + bitmap: Arc<RoaringBitmap>, +} + +/// Magic number for BitmapDeletionVector serialization format +/// Same as Java: 1581511376 +const MAGIC_NUMBER: u32 = 1581511376; +const MAGIC_NUMBER_SIZE_BYTES: usize = 4; + +impl DeletionVector { + /// Create a new empty DeletionVector + pub fn empty() -> Self { + Self { + bitmap: Arc::new(RoaringBitmap::new()), + } + } + + /// Create a new DeletionVector from a RoaringBitmap + pub fn from_bitmap(bitmap: RoaringBitmap) -> Self { + Self { + bitmap: Arc::new(bitmap), + } + } + + /// Check if a row at the given position is deleted + pub fn is_deleted(&self, row_position: u64) -> bool { + // RoaringBitmap32 in Java supports up to 2^31-1, so we check u32 range + if row_position > u32::MAX as u64 { + return false; Review Comment: paimon java throw exception here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
