juntaozhang commented on code in PR #7409:
URL: https://github.com/apache/paimon/pull/7409#discussion_r2935300971


##########
paimon-core/src/main/java/org/apache/paimon/append/AppendCompactTask.java:
##########
@@ -49,6 +50,7 @@ public class AppendCompactTask {
 
     public AppendCompactTask(BinaryRow partition, List<DataFileMeta> files) {
         Preconditions.checkArgument(files != null);
+        files.sort(Comparator.comparingLong(DataFileMeta::minSequenceNumber));

Review Comment:
   Hi @JingsongLi , sorry for the late reply.
   
   This fix is mainly targeted at the row-tracking scenario. Given that 
`sequenceNumber` may not be continuous and can even be null, I’ve revised the 
original implementation to manage this logic within `RowDataFileWriter`.
   
   Thanks for your time and help. Could you please take another look for this 
PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to