plusplusjiajia commented on code in PR #7577:
URL: https://github.com/apache/paimon/pull/7577#discussion_r3026004120
##########
paimon-api/src/main/java/org/apache/paimon/rest/auth/DLFOpenApiSigner.java:
##########
@@ -65,7 +66,7 @@ public class DLFOpenApiSigner implements DLFRequestSigner {
private static final String API_VERSION = "2026-01-18";
private static final DateTimeFormatter GMT_DATE_FORMATTER =
- DateTimeFormatter.ofPattern("EEE, dd MMM yyyy HH:mm:ss 'GMT'")
+ DateTimeFormatter.ofPattern("EEE, dd MMM yyyy HH:mm:ss 'GMT'",
Locale.ENGLISH)
Review Comment:
> Do we need to modify python too?
Python's strftime is locale-safe by default, unlike Java.
Here's the key difference:
Python: On startup, LC_TIME defaults to the C locale ((None, None)), so
strftime("%a") always outputs English (e.g., Mon, Tue) regardless of the OS
system locale.
Java: DateTimeFormatter uses Locale.getDefault(), which follows the system
locale. On a Chinese system, it produces ζζδΈ instead of Mon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
