QuakeWang commented on code in PR #190: URL: https://github.com/apache/paimon-rust/pull/190#discussion_r3026280593
########## crates/integrations/datafusion/src/filter_pushdown.rs: ########## @@ -0,0 +1,525 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use datafusion::common::{Column, ScalarValue}; +use datafusion::logical_expr::expr::InList; +use datafusion::logical_expr::{Between, BinaryExpr, Expr, Operator, TableProviderFilterPushDown}; +use paimon::spec::{DataField, DataType, Datum, Predicate, PredicateBuilder}; + +pub(crate) fn classify_filter_pushdown( + filter: &Expr, + fields: &[DataField], + partition_keys: &[String], +) -> TableProviderFilterPushDown { + let translator = PartitionFilterTranslator::new(fields, partition_keys); + if translator.translate(filter).is_some() { + TableProviderFilterPushDown::Exact + } else if split_conjunction(filter) + .into_iter() + .any(|expr| translator.translate(expr).is_some()) + { + TableProviderFilterPushDown::Inexact + } else { + TableProviderFilterPushDown::Unsupported + } +} + +pub(crate) fn build_pushed_predicate( + filters: &[Expr], + fields: &[DataField], + partition_keys: &[String], +) -> Option<Predicate> { + let translator = PartitionFilterTranslator::new(fields, partition_keys); Review Comment: > Why we just limit this to partition filter? Just pass all filters and let scan deal with this. @JingsongLi Thanks for the review. You're right, this is the wrong boundary. The current implementation couples "which filters are translated/passed to scan" with "which filters are currently used for partition pruning". `TableScan` already accepts a full table-schema `Predicate` and extracts partition conjuncts internally, so restricting translation here to partition columns is too narrow. I'll update the DataFusion side to pass all translatable filters down to scan, while keeping `Exact` only for predicates we can evaluate exactly today. Filters that are translatable but not fully enforced by the scan yet will remain `Inexact`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
