JingsongLi commented on code in PR #192:
URL: https://github.com/apache/paimon-rust/pull/192#discussion_r3031705777
##########
crates/paimon/src/io/file_io.rs:
##########
@@ -65,11 +65,13 @@ impl FileIO {
})?;
Ok(FileIOBuilder::new(url.scheme()))
}
+}
+// Implement FileIOProvider for FileIO
+use crate::io::FileIOProvider;
- /// Create a new input file to read data.
- ///
- /// Reference:
<https://github.com/apache/paimon/blob/release-0.8.2/paimon-common/src/main/java/org/apache/paimon/fs/FileIO.java#L76>
- pub fn new_input(&self, path: &str) -> crate::Result<InputFile> {
+#[async_trait::async_trait]
+impl FileIOProvider for FileIO {
+ async fn new_input(&self, path: &str) -> Result<InputFile> {
Review Comment:
Why need to do this refactor? sync to async?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
