QuakeWang commented on code in PR #224:
URL: https://github.com/apache/paimon-rust/pull/224#discussion_r3045040747
##########
crates/integrations/datafusion/src/physical_plan/scan.rs:
##########
@@ -124,6 +357,35 @@ impl ExecutionPlan for PaimonTableScan {
Ok(self)
}
+ fn with_fetch(&self, fetch: Option<usize>) -> Option<Arc<dyn
ExecutionPlan>> {
+ if self.scan_fetch_mode != ScanFetchMode::Exact {
+ return None;
+ }
+
+ let fetch = fetch.filter(|fetch| *fetch > 0);
Review Comment:
Good catch. I removed the `fetch > 0` normalization so `Some(0)` is
preserved as part of the physical fetch contract, and I added tests to cover
the zero-fetch path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
