plusplusjiajia commented on code in PR #240:
URL: https://github.com/apache/paimon-rust/pull/240#discussion_r3073179120
##########
crates/integrations/datafusion/src/catalog.rs:
##########
@@ -112,6 +145,43 @@ impl PaimonSchemaProvider {
pub fn new(catalog: Arc<dyn Catalog>, database: String) -> Self {
PaimonSchemaProvider { catalog, database }
}
+
+ /// Resolves `<base>$<system_name>` into a system table provider.
+ ///
+ /// Unknown system names return `Ok(None)` (DataFusion reports "table not
+ /// found"). When the system name is registered but the base table is
+ /// missing, an explicit error is returned so users can tell the two cases
+ /// apart in error messages.
+ async fn load_system_table(
Review Comment:
> Put these methods to system_tables/mod.
Thanks for the suggestion! Moved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
