shyjsarah opened a new pull request, #273:
URL: https://github.com/apache/paimon-rust/pull/273
…wallow errors
The CatalogProvider/SchemaProvider trait methods schema_names(), schema(),
table_names(), and table_exist() have no Result return type, so errors from
remote catalog operations were silently discarded. Add log::error! to surface
these failures for debugging.
<!--
Thank you very much for contributing to Paimon Rust - we are happy that you
want to help us improve it. To help the community review your contribution in
the best possible way, please go through the checklist below, which will get
the contribution into a shape in which it can be best reviewed.
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/paimon-rust/issues). Exceptions are made for
typos in documentation or comments, which need no issue.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `cargo test`
passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
Linked issue: N/A (no existing issue — upstream trait limitation)
Add `log::error!` to 4 `CatalogProvider`/`SchemaProvider` trait methods
that silently discard errors from remote catalog operations, making failures
visible for debugging.
### Brief change log
- `schema_names()`: replace `unwrap_or_default()` with `match` +
`log::error!` on `Err`
- `schema()`: replace `Err(_) => None` with `log::error!` before returning
`None`
- `table_names()`: replace `unwrap_or_default()` with `match` +
`log::error!` on `Err`
- `table_exist()`: replace `Err(_) => false` with `log::error!` before
returning `false`
- Add `log = "0.4"` dependency to `paimon-datafusion`
These 4 methods have no `Result` return type in the upstream DataFusion
trait, so logging is the best we can do. A proper fix requires changing the
upstream trait signatures (to
be proposed separately as a breaking API change on apache/datafusion).
### Tests
- Existing tests pass (`cargo test -p paimon-datafusion`)
- Manual: set `RUST_LOG=error` and trigger a catalog error to verify log
output
### API and Format
No API or format changes.
### Documentation
No documentation changes needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
