jerry-024 commented on code in PR #274:
URL: https://github.com/apache/paimon-rust/pull/274#discussion_r3123377426
##########
crates/integrations/datafusion/src/catalog.rs:
##########
@@ -54,7 +57,18 @@ impl PaimonCatalogProvider {
///
/// All data is loaded lazily when accessed.
pub fn new(catalog: Arc<dyn Catalog>) -> Self {
- PaimonCatalogProvider { catalog }
+ Self::with_dynamic_options(catalog, Default::default())
Review Comment:
PaimonCatalogProvider::new() now creates its own fresh DynamicOptions, and
PaimonSqlHandler::new() does the same. That means the default public
construction path does not actually share session state: SET paimon.* mutates
the handler-local map, but later table resolution here reads from a different
map. Unless every caller switches to with_dynamic_options(...) on both sides,
the feature is effectively broken for the documented/default API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
