plusplusjiajia commented on code in PR #264:
URL: https://github.com/apache/paimon-rust/pull/264#discussion_r3130833459
##########
crates/paimon/src/table/snapshot_manager.rs:
##########
@@ -90,26 +91,20 @@ impl SnapshotManager {
id_str.trim().parse().ok()
}
- /// List snapshot files and find the id using the given reducer (min or
max).
- async fn find_by_list_files(&self, reducer: fn(i64, i64) -> i64) ->
crate::Result<Option<i64>> {
Review Comment:
The refactor shares the directory-scan logic between the existing
find_by_list_files and the new list_all_ids, I will revert it to keep this PR
scoped to $snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
