XiaoHongbo-Hope commented on code in PR #7681:
URL: https://github.com/apache/paimon/pull/7681#discussion_r3141939529
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -204,10 +204,13 @@ public static void validateTableSchema(TableSchema
schema) {
CoreOptions.STREAMING_READ_APPEND_OVERWRITE.key()));
}
- if
(schema.options().containsKey(CoreOptions.PARTITION_EXPIRATION_TIME.key())) {
- if (schema.partitionKeys().isEmpty()) {
+ if (schema.partitionKeys().isEmpty()) {
+ for (String key : schema.options().keySet()) {
+ if (!CoreOptions.requiresPartitionedTable(key)) {
+ continue;
+ }
throw new IllegalArgumentException(
- "Can not set 'partition.expiration-time' for
non-partitioned table.");
Review Comment:
> Just remove this?
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
