XiaoHongbo-Hope commented on code in PR #280:
URL: https://github.com/apache/paimon-rust/pull/280#discussion_r3142047187
##########
crates/paimon/src/table/bucket_assigner.rs:
##########
@@ -97,4 +97,10 @@ impl BucketAssignerEnum {
Self::CrossPartition(a) => a.prepare_commit_index(file_io,
index_dir).await,
}
}
+
+ pub fn set_overwrite(&mut self, is_overwrite: bool) {
+ if let Self::Dynamic(a) = self {
Review Comment:
set_overwrite() does not affect CrossPartitionAssigner. With cross-partition
PK tables and merge-engine='first-row', INSERT OVERWRITE ... PARTITION can
delete old data without writing the replacement
row, causing data loss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
