kerwin-zk commented on PR #7648: URL: https://github.com/apache/paimon/pull/7648#issuecomment-4331883529
> @kerwin-zk I have some thoughts which may be worth considering. > > 1. These classes (`PaimonFormatTable`, `ScanPlanHelper`, `PaimonBatchWrite`, `AbstractPaimonSparkSqlExtensionsParser`, `PaimonStrategyHelper`, `PaimonCreateTableAsSelectStrategy` and `PaimonRelation`) maybe don't have to copy to `paimon-spark-4.0` cause these use the stable api. Please check. > 2. And For classes (`AssignmentAlignmentHelper`, `PaimonMergeIntoResolver`, `PaimonMergeIntoResolverBase`, `RewriteUpsertTable`, `MergeIntoPaimonTable`and `MergeIntoPaimonDataEvolutionTable`), can we identify specific incompatibilities and then draw them into 'SparkShim' to solve them? @YannByron `PaimonRelation` has been removed, and the rest need some refactoring. After this PR is merged, I will submit follow-up PRs to refactor and optimize this part of the logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
