XiaoHongbo-Hope commented on code in PR #7589:
URL: https://github.com/apache/paimon/pull/7589#discussion_r3153934313
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1045,6 +1050,7 @@ CommitResult tryCommitOnce(
if (strictModeChecker != null) {
strictModeChecker.update(newSnapshotId);
}
+ lastCommittedSnapshotId = newSnapshotId;
Review Comment:
This misses the duplicate-success retry path. In false-success retry, the
earlier duplicate-check branch returns before this assignment, so the gauge can
stay `-1`.Should we also set `lastCommittedSnapshotId = snapshot.id()` there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
