TheR1sing3un commented on PR #7738: URL: https://github.com/apache/paimon/pull/7738#issuecomment-4345185022
Pushed [a913e1461](https://github.com/apache/paimon/pull/7738/commits/a913e1461) addressing the review: - `Identifier(..., branch=...)` constructor kwarg restored, internally encodes into `object`, emits `DeprecationWarning`. - `identifier.branch` re-exposed as a `@property` delegating to `get_branch_name()`, also `DeprecationWarning`. - `Identifier.create(db, "tbl$snapshots")` legacy two-arg form (raw object containing `$`, no `branch=` / `system_table=` kwargs) routes back to the raw-object behaviour, with `DeprecationWarning`. - 8 new cases in `IdentifierBackwardCompatibilityShimTest` lock in both the warnings and the equivalent-result behaviour, so the shim can't get silently dropped. - PR description now has a migration table; deprecation removal targeted at the next minor release. Kept the two correctness fixes — `SYSTEM_BRANCH_PREFIX = 'branch_'` and dropping the un-round-trippable `branch` JSON field — as-is. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
