JingsongLi commented on code in PR #7793:
URL: https://github.com/apache/paimon/pull/7793#discussion_r3217058980
##########
paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java:
##########
@@ -469,16 +469,22 @@ public ExpireSnapshots newExpireChangelog() {
public TableCommitImpl newCommit(String commitUser) {
CoreOptions options = coreOptions();
return new TableCommitImpl(
- store().newCommit(commitUser, this),
- newExpireRunnable(),
- options.writeOnly() ? null :
store().newPartitionExpire(commitUser, this),
- options.writeOnly() ? null : store().newTagAutoManager(this),
- options.writeOnly() ? null :
CoreOptions.fromMap(options()).consumerExpireTime(),
- new ConsumerManager(fileIO, path, snapshotManager().branch()),
- options.snapshotExpireExecutionMode(),
- name(),
- options.forceCreatingSnapshot(),
- options.fileOperationThreadNum());
+ store().newCommit(commitUser, this),
+ newExpireRunnable(),
+ options.writeOnly() ? null :
store().newPartitionExpire(commitUser, this),
+ options.writeOnly() ? null :
store().newTagAutoManager(this),
+ options.writeOnly()
+ ? null
+ :
CoreOptions.fromMap(options()).consumerExpireTime(),
+ new ConsumerManager(fileIO, path,
snapshotManager().branch()),
+ options.snapshotExpireExecutionMode(),
+ name(),
+ options.forceCreatingSnapshot(),
+ options.fileOperationThreadNum())
+ .checkSameBucket(
+ bucketMode() == BucketMode.HASH_FIXED
+ && options.writeOnly()
+ && !options.bucketAppendOrdered());
Review Comment:
FileStoreCommitImpl already has options, can you just check it inside?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
