leaves12138 commented on PR #7847: URL: https://github.com/apache/paimon/pull/7847#issuecomment-4449076164
Thanks for the patch. The null encoding/decoding is aligned with the Java blob format. One edge case: accepts before validating that the field is actually a BLOB field. This means a non-BLOB single-column Arrow table with all-null values, e.g. or , can now be written as a valid blob file, while non-null values of the same type are still rejected. Could we validate the field type before accepting nulls, or add a -level check that only is supported? Also, the null cases currently only assert that the file exists. It would be better to add a public API round-trip test, e.g. write through and read it back with to verify the null value is preserved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
