chenghuichen commented on PR #7673: URL: https://github.com/apache/paimon/pull/7673#issuecomment-4458064500
@leaves12138 Thanks for catching this! The `_ROW_ID` correctness issue makes total sense. Fixed both cases: - SlicedSplit: offset `first_row_id` by `shard_range[0]` for correct `_ROW_ID` - IndexedSplit: pass local offsets to `DataFileBatchReader` for per-row `_ROW_ID` assignment Added e2e regression tests (with_shard + `_ROW_ID` projection, IndexedSplit + `_ROW_ID`). For the `vortex.array(range(...))` concern: benchmarked with 20M rows, native pushdown shows ~5% speedup over ShardBatchReader. [bench_shard_pushdown.py](https://github.com/user-attachments/files/27792184/bench_shard_pushdown.py) The gain is modest since Lance/Vortex readers still fetch full files before selecting rows, but this path will benefit directly once fine-grained byte-range reads land (lance-format/lance#1929). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
