XiaoHongbo-Hope commented on code in PR #7897: URL: https://github.com/apache/paimon/pull/7897#discussion_r3265937791
########## paimon-core/src/main/java/org/apache/paimon/tag/BatchReadTagCreator.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.tag; + +import org.apache.paimon.Snapshot; +import org.apache.paimon.utils.SnapshotManager; +import org.apache.paimon.utils.TagManager; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import javax.annotation.Nullable; + +import java.time.Duration; +import java.util.Collections; +import java.util.UUID; + +/** Creates temporary tags to protect snapshots from expiration during batch reads. */ +public class BatchReadTagCreator { + + private static final Logger LOG = LoggerFactory.getLogger(BatchReadTagCreator.class); + + public static final String BATCH_READ_TAG_PREFIX = "batch-read-"; + + private final TagManager tagManager; + private final SnapshotManager snapshotManager; + private final Duration timeRetained; + + public BatchReadTagCreator( + TagManager tagManager, SnapshotManager snapshotManager, Duration timeRetained) { + this.tagManager = tagManager; + this.snapshotManager = snapshotManager; + this.timeRetained = timeRetained; + } + + @Nullable + public String createReadTag(long snapshotId) { + Snapshot snapshot; + try { + snapshot = snapshotManager.snapshot(snapshotId); + } catch (Exception e) { + LOG.warn("Failed to get snapshot {} for read protection tag.", snapshotId, e); + return null; + } + + String tagName = generateTagName(snapshotId); + try { + tagManager.createTag(snapshot, tagName, timeRetained, Collections.emptyList(), true); + LOG.info( + "Created batch read protection tag '{}' for snapshot {}.", tagName, snapshotId); + return tagName; + } catch (Exception e) { + LOG.warn( + "Failed to create batch read protection tag for snapshot {}. " + + "Read will proceed without protection.", + snapshotId, + e); + return null; + } + } + + public void deleteReadTag(String tagName) { + try { + if (tagManager.tagExists(tagName)) { + snapshotManager.fileIO().deleteQuietly(tagManager.tagPath(tagName)); Review Comment: Is this intentionally deleting only the tag meta file instead of calling table.deleteTag(tagName) to keep read cleanup lightweight -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
