shyjsarah commented on code in PR #7902:
URL: https://github.com/apache/paimon/pull/7902#discussion_r3272448556
##########
paimon-python/pypaimon/filesystem/jindo_file_system_handler.py:
##########
@@ -24,17 +24,83 @@
try:
import pyjindo.fs as jfs
+ import pyjindo.ossfs as jossfs
Review Comment:
Thanks — agreed, fixed in e989d453.
Split into two independent flags so the two pyjindosdk surfaces are
tracked separately:
```python
try:
import pyjindo.fs as jfs
import pyjindo.util as jutil
JINDO_AVAILABLE = True
except ImportError:
JINDO_AVAILABLE = False
jfs = jutil = None
try:
import pyjindo.ossfs as jossfs
JINDO_OSSFS_AVAILABLE = True
except ImportError:
jossfs = None
JINDO_OSSFS_AVAILABLE = False
- build_jindo_config keeps the JINDO_AVAILABLE gate (only needs jutil).
- create_jindo_oss_filesystem and
PaimonVirtualFileSystem._use_jindo_oss_backend now require both flags, so a
pyjindosdk build that ships fs/util but not ossfs no longer flips the PyArrow
JindoFileSystemHandler path
to unavailable.
- pvfs.py imports JINDO_OSSFS_AVAILABLE from the handler module.
- test_jindo_falls_back_to_ossfs_when_pyjindo_ossfs_missing (renamed) now
patches JINDO_OSSFS_AVAILABLE and pins JINDO_AVAILABLE=True, so the result is
independent of whether pyjindosdk is installed in the CI image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
