leaves12138 commented on code in PR #7922:
URL: https://github.com/apache/paimon/pull/7922#discussion_r3279858503


##########
docs/docusaurus.config.js:
##########
@@ -0,0 +1,180 @@
+// @ts-check
+
+/** @type {import('@docusaurus/types').Config} */
+const config = {
+  title: 'Apache Paimon',
+  tagline: 'Data Lake Platform',
+  favicon: 'favicon.png',
+
+  url: 'https://paimon.apache.org',
+  baseUrl: '/docs/master/',
+
+  organizationName: 'apache',
+  projectName: 'paimon',
+
+  onBrokenLinks: 'warn',
+
+  markdown: {
+    format: 'detect',
+    mdx1Compat: {
+      comments: true,
+      admonitions: true,
+      headingIds: true,
+    },
+  },
+
+  i18n: {
+    defaultLocale: 'en',
+    locales: ['en'],
+  },
+
+  customFields: {
+    version: '1.5-SNAPSHOT',
+    versionTitle: '1.5-SNAPSHOT',
+    branch: 'master',
+    flinkVersion: '1.20',
+    isStable: false,
+    showOutDatedWarning: false,
+    githubRepo: 'https://github.com/apache/paimon.git',
+    trinoGithubRepo: 'https://github.com/apache/paimon-trino.git',
+    prestoGithubRepo: 'https://github.com/apache/paimon-presto.git',
+    scalaVersion: '_2.12',
+    stableDocs: 'https://paimon.apache.org/docs/1.4',
+    previousDocs: [
+      {label: 'master', href: 'https://paimon.apache.org/docs/master'},
+      {label: 'stable (1.4)', href: 'https://paimon.apache.org/docs/1.4'},
+      {label: '1.3', href: 'https://paimon.apache.org/docs/1.3'},
+      {label: '1.2', href: 'https://paimon.apache.org/docs/1.2'},
+      {label: '1.1', href: 'https://paimon.apache.org/docs/1.1'},
+    ],
+  },
+
+  presets: [
+    [
+      'classic',
+      /** @type {import('@docusaurus/preset-classic').Options} */
+      ({
+        docs: {
+          routeBasePath: '/',
+          sidebarPath: './sidebars.js',
+          editUrl: 'https://github.com/apache/paimon/edit/master/docs/',
+          beforeDefaultRemarkPlugins: [
+            require('./src/plugins/remark-variable-interpolation'),
+          ],
+        },
+        blog: false,
+        theme: {
+          customCss: './src/css/custom.css',
+        },
+      }),
+    ],
+  ],
+
+  themes: [
+    [
+      require.resolve('@easyops-cn/docusaurus-search-local'),
+      {
+        hashed: true,
+        language: ['en'],
+        indexBlog: false,
+        docsRouteBasePath: '/',
+      },
+    ],
+  ],
+
+  plugins: [
+    [
+      '@docusaurus/plugin-client-redirects',
+      {
+        redirects: [],

Review Comment:
   `docs/redirects.js` is generated with the Hugo aliases, but it is never 
imported here; the plugin is configured with an empty array. As a result, the 
build does not create the expected old `.html` redirect pages. I verified that 
after `yarn build`, paths such as `build/append-table/blob-storage.html`, 
`build/cdc-ingestion/flink-cdc.html`, and `build/concepts/basic-concepts.html` 
are missing while the new canonical pages exist. Please wire this to 
`require('./redirects')` (or inline the generated redirects) so existing 
external links keep working after the migration.



##########
docs/docusaurus.config.js:
##########
@@ -0,0 +1,180 @@
+// @ts-check
+
+/** @type {import('@docusaurus/types').Config} */
+const config = {
+  title: 'Apache Paimon',
+  tagline: 'Data Lake Platform',
+  favicon: 'favicon.png',
+
+  url: 'https://paimon.apache.org',
+  baseUrl: '/docs/master/',
+
+  organizationName: 'apache',
+  projectName: 'paimon',
+
+  onBrokenLinks: 'warn',

Review Comment:
   `yarn build` currently succeeds but emits broken-anchor warnings for several 
migrated links, for example `../flink/procedures#procedures`, 
`./#options-table`, `../maintenance/manage-snapshots#expiring-snapshots`, and 
the self links in `project/contributing`. These become broken in-page 
navigations in the generated site, and CI will not catch regressions while they 
are warnings. Please fix the current broken anchors and consider setting 
`onBrokenAnchors: 'throw'` for this migration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to