shidayang commented on code in PR #7886:
URL: https://github.com/apache/paimon/pull/7886#discussion_r3281221638
##########
paimon-core/src/main/java/org/apache/paimon/append/AppendOnlyWriter.java:
##########
@@ -174,16 +186,31 @@ public AppendOnlyWriter(
}
}
- private BufferedSinkWriter<InternalRow> createBufferedSinkWriter(boolean
spillable) {
- return new BufferedSinkWriter<>(
- this::createRollingRowWriter,
- t -> t,
- t -> t,
- ioManager,
- writeSchema,
- spillable,
- maxDiskSize,
- spillCompression);
+ private SinkWriter<InternalRow> createSinkWriter(boolean useWriteBuffer,
boolean spillable) {
+ if (useWriteBuffer) {
Review Comment:
When sortEnabled is enabled, should we throw an error if useWriteBuffer is
false ? Otherwise, it is hard for users to notice this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
