steFaiz commented on PR #7921: URL: https://github.com/apache/paimon/pull/7921#issuecomment-4514843912
@leaves12138 Thanks for your review! For the test failure: could you please add the `-am` option to this command? The check logic is in paimon-core module, the `-pl` option will not compile other modules. For the second issue: >In particular, Flink's alterTable(..., newTable, tableChanges, ...) should probably compute blob type fields from old table options merged with the incoming option changes Flink do not need to do this, because the `newTable` param is already the altered table schema, I just get the final option from the new table. But thanks for your remind! I've added the test that both add column and set option in a single method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
