QuakeWang commented on code in PR #33: URL: https://github.com/apache/paimon-mosaic/pull/33#discussion_r3287171159
########## core/src/spec.rs: ########## @@ -21,6 +21,7 @@ pub const FOOTER_SIZE: usize = 32; pub const COMPRESSION_NONE: u8 = 0; pub const COMPRESSION_ZSTD: u8 = 1; +pub const COMPRESSION_LZ4: u8 = 2; Review Comment: Adding a new on-disk compression id makes this a format/API-level change, but the public bindings and docs are not updated consistently. Java exposes COMPRESSION_LZ4, while Python still only exposes NONE/ZSTD, C++ has no named constant, and the format/API docs still say only `0 = none, 1 = zstd` and that paged buckets require ZSTD. Please update the Python/C++ public APIs, docs, and at least add cross-language roundtrip coverage for `compression = 2`, so the new codec has one consistent meaning across all supported entry points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
