LsomeYeah commented on code in PR #7923:
URL: https://github.com/apache/paimon/pull/7923#discussion_r3287440833
##########
paimon-core/src/main/java/org/apache/paimon/table/ExpireChangelogImpl.java:
##########
@@ -130,10 +130,20 @@ public int expire() {
// Only clean the snapshot in changelog dir
maxExclusive = Math.min(maxExclusive, latestChangelogId);
+ if (maxExclusive <= earliestChangelogId) {
+ // This happens when retainMin >= total changelog count
+ // (e.g. latestSnapshotId - retainMin + 1 <= earliestChangelogId),
Review Comment:
nit: trailing comma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
