leaves12138 commented on PR #6: URL: https://github.com/apache/paimon-cpp/pull/6#issuecomment-4517967547
I re-checked this after the clarification. `DefineOptions.cmake` does block explicit `-DArrow_SOURCE=SYSTEM` and `-DORC_SOURCE=SYSTEM`, but it does not fully prevent system Arrow/ORC in the current PR: * if `PAIMON_DEPENDENCY_SOURCE=SYSTEM` is used and `Arrow_SOURCE` / `ORC_SOURCE` are left empty, `paimon_get_dependency_source()` falls back to `PAIMON_DEPENDENCY_SOURCE`, so Arrow/ORC can still resolve as `SYSTEM`; * if `PAIMON_DEPENDENCY_SOURCE=AUTO` (the default) and system Arrow/ORC are found, this PR's `paimon_configure_dependency_root()` keeps `AUTO`, then `resolve_dependency()` can choose `ArrowAlt` / `ORCAlt` as system dependencies. The source snapshot had an additional guard in `ThirdpartyToolchain.cmake` that forced Arrow/ORC `AUTO` to `BUNDLED` and rejected Arrow/ORC `SYSTEM`, because these dependencies need project-specific patches. That guard is removed in this PR, so the blocker still stands. The LICENSE/NOTICE attribution blocker also still stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
