ArnavBalyan commented on PR #7906:
URL: https://github.com/apache/paimon/pull/7906#issuecomment-4525749556

   Thanks for the review! 
   1. retract() method has the same overflow bug but is not fixed
   > Covered all cases, division and multiplication are now guarded and will 
not silently corrupt data
   
   2. Exception message could include operand values for debuggability
   > Made exception more clear and descriptive
   
   3. Consider the failure mode during compaction
   > Added more documentation to this PR for posterity


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to