ArnavBalyan commented on PR #7824:
URL: https://github.com/apache/paimon/pull/7824#issuecomment-4526922733
Thanks for the review! Have addressed all comments
**1. Partition column ordering assumption**
Added a check that throws a clear error when partition columns aren't the
trailing columns of the schema. Covered by a new unit test.
**2. Mixed static/dynamic partitions**
Documented why we fall back to the unwrapped writer when a partition key
has no value in the path, and flags this as a known unsupported case.
**3. Separator in the partition columns property**
Extracted the forward slash into a constant with a comment explaining it's
the Hive metastore convention, not the OS path separator.
**4. Direct access to the underlying batch write**
Added a write method on the inner writer. Both the wrapped and unwrapped
paths now go through this, so any future logic added to the write path won't be
silently bypassed.
**5. Inconsistent exception wrapping**
Aligned both write paths to throw the same exception type, so error
handling upstream is consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
