Zouxxyy commented on code in PR #7924:
URL: https://github.com/apache/paimon/pull/7924#discussion_r3296463749
##########
paimon-spark/paimon-spark-4.0/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/AbstractPaimonSparkSqlExtensionsParser.scala:
##########
@@ -52,30 +52,76 @@ import scala.collection.JavaConverters._
* @param delegate
* The extension parser.
*/
+// Keep this class in the Spark 4.0 module so it is compiled against Spark
4.0's ParserInterface.
abstract class AbstractPaimonSparkSqlExtensionsParser(val delegate:
ParserInterface)
extends org.apache.spark.sql.catalyst.parser.ParserInterface
with Logging {
private lazy val substitutor = new VariableSubstitution()
private lazy val astBuilder = new PaimonSqlExtensionsAstBuilder(delegate)
+ private val nonReservedIdentifierTokenTypes = Set(
Review Comment:
What are these effects?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
