leaves12138 commented on PR #22: URL: https://github.com/apache/paimon-cpp/pull/22#issuecomment-4552602854
Re-reviewed the current head (`94b3929`). The two blocking issues I found are already listed in my latest review comments: the decimal setter switches on the wrong Arrow decimal enum, and non-compact decimal writes do not validate/normalize scale. I did not find additional blockers in this pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
